Closed mpociot closed 2 months ago
I always assume patches is for latest releases, so just update it. If necessary, add a note in readme.
As for 8.2, we may need another patch file.
Okay, then I think @crazywhalecc needs to see how he wants to solve PHP backwards compatibility inside static-php-cli.
Regarding the fact that with the new patch, opcache is not working as expected, I'm not sure if that's an issue in micro or the static-php codebase.
The changes I can think of at the moment are:
EDIT: don't need to consider old version of php-src.
I just updated the PR with the PHP 8.2 patch provided by @crazywhalecc Nevermind the issue I had with opcache not being correctly enabled, it was an error on my end. Sorry about that!
I think this is good to go from my side then
PHP 8.3.11 (and 8.2.23) changed these lines in their
ext/opcache/config.m4
which leads to issues that the patch file can not be applied.https://github.com/php/php-src/compare/php-8.3.10...php-8.3.11#diff-fba8aed1e512099e6635bd4d9ffd939e0489105bc6b2c68d0bfe1abb0ee1007cR322
This PR fixes the patch file for PHP 8.3 - but there are some things missing where I could use your help:
Please note that I'm not using phpmicro directly, but via static-php-cli. Also see this issue https://github.com/crazywhalecc/static-php-cli/issues/527
static-php-cli
with this patch applied, the opcache extension is missing. Not sure if this is an issue in phpmicro or in static-php-cli~