search

easystats / bayestestR

:ghost: Utilities for analyzing Bayesian models and posterior distributions
https://easystats.github.io/bayestestR/
GNU General Public License v3.0
563 stars 55 forks source link

use new dlogspline #633

Closed mattansb closed 7 months ago

mattansb commented 11 months ago

This PR improves precision of logBFs in bayesfactor_parameters.

All tests related to those changes pass.

strengejacke commented 11 months ago

Could there be an issue with this warning:

Can't install dependency logspline (>= 2.1.21)

?

@IndrajeetPatil

mattansb commented 11 months ago

Yeah, the package was pushed to CRAN like an hour an a half ago - so the binaries aren't available yet 😅

DominiqueMakowski commented 7 months ago

Can we merge this?

mattansb commented 7 months ago

If tests are passing (they should) - yes!

codecov[bot] commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bb68c2b) 52.41% compared to head (dacbed3) 52.51%.

Files Patch % Lines
R/bayesfactor_models.R 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #633 +/- ## ========================================== + Coverage 52.41% 52.51% +0.09% ========================================== Files 65 65 Lines 5334 5315 -19 ========================================== - Hits 2796 2791 -5 + Misses 2538 2524 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DominiqueMakowski commented 7 months ago

"Passing tests on bayestestR"

mattansb commented 7 months ago

Bam!