easystats / bayestestR

:ghost: Utilities for analyzing Bayesian models and posterior distributions
https://easystats.github.io/bayestestR/
GNU General Public License v3.0
575 stars 55 forks source link

CRAN submission #641

Closed strengejacke closed 8 months ago

strengejacke commented 9 months ago

@DominiqueMakowski I think we can submit a new version to CRAN, no? Last update is quite some time ago, and we have made several fixes in between.

strengejacke commented 9 months ago

@DominiqueMakowski What are the results from win builder?

strengejacke commented 9 months ago

@DominiqueMakowski ping

DominiqueMakowski commented 9 months ago

Sorry I missed this !

Mismatches for apparent methods not registered: .clean_priors_and_posteriors: function(posterior, prior, verbose, ...) .clean_priors_and_posteriors.emm_list: function(posterior, prior, verbose)

.clean_priors_and_posteriors: function(posterior, prior, verbose, ...) .clean_priors_and_posteriors.emmGrid: function(posterior, prior, verbose)

Missing link or links in Rd file 'p_direction.Rd': 'pd_tp_p' 'density estimation

strengejacke commented 9 months ago

Ok, should be fixed in https://github.com/easystats/bayestestR/commit/ffd511fd65757685f63fe62500e8405725e968ff

strengejacke commented 9 months ago

@mattansb When fixing this, I realized that the .clean_priors_and_posteriors() is called from bayesfactor_parameters.stanreg() with a parameters argument, but that argument seems to have no effect in .clean_priors_and_posteriors.stanreg()?

strengejacke commented 9 months ago

I think you can submit.

mattansb commented 9 months ago

@strengejacke Oops, fixing that here #642

DominiqueMakowski commented 9 months ago

submitted (with bumped version) gosh it feels like haven't done that for years lol

DominiqueMakowski commented 9 months ago

They are not:

Unknown, possibly misspelled, fields in DESCRIPTION: 'Remotes'

Please drop that field.

Flavor: r-devel-windows-x86_64 Check: examples, Result: NOTE Examples with CPU (user + system) or elapsed time > 10s user system elapsed bayesfactor_parameters 5.17 0.14 55.17

Please reduce each example to less than 5 sec.


This 5 sec rule is starting to be a bit annoying

strengejacke commented 9 months ago

I think these issues should be fixed on main.

DominiqueMakowski commented 8 months ago

It should be on CRAN