easystats / blog

:mega: The collaborative blog
https://easystats.github.io/blog/
10 stars 1 forks source link

Dealing with images paths #11

Closed DominiqueMakowski closed 5 years ago

DominiqueMakowski commented 5 years ago

https://github.com/rstudio/blogdown/issues/45

seems that either we manually copy the images to the static folder and then link them accordingly, or it might want if we set relative paths to False here. However, I remember having some issues with this when I tried to set this blog up, so it'll be safer to do some experiments in a few days.

DominiqueMakowski commented 5 years ago

I have asked on stack overflow, blogdown issue here, but no answer yet 😞

DominiqueMakowski commented 5 years ago

https://github.com/rstudio/blogdown/issues/380#event-2292312822

well...

DominiqueMakowski commented 5 years ago

Ok, I don't know what I did (mainly nothing) but suddenly it seems to work, i.e., we have full URLs and the images are working on the blog (and should work, if the URL stays the same, on r-bloggers)... we have to test it.

DominiqueMakowski commented 5 years ago

As you've seen, despite having the full URLs, these are somehow wrongly parsed to r-bloggers. Investigating further...

DominiqueMakowski commented 5 years ago

I did something and I hope it's fixed. I am waiting for confirmation for r-bloggers' maintainer.

DominiqueMakowski commented 5 years ago

the images are still not showing :'( will investigate futher

DominiqueMakowski commented 5 years ago

I'll try this solution

DominiqueMakowski commented 5 years ago

I've now manually fixed your latest post, so that people could see it with images. However, as of now, I've removed your feed from r-bloggers and new posts will NOT be added. In order to get your feed back to the site, please fix it so that the images will be properly linked to. You could have checked yourself in the following link to have seen that you still have /blog/blog in your img urls in the feed: https://easystats.github.io/blog/categories/r/index.xml Once fixed, please let me know and I'll add your feed back.

DominiqueMakowski commented 5 years ago

The last resort alternative would be to manually replace all the "/blog" characters in the RSS feed by the website's URL but... it would be good to find how to solve it automatically through blogdown 😕

DominiqueMakowski commented 5 years ago

I have updated the README to add instructions on how to manually fix the RSS feed so it is correctly displayed on R-bloggers... It should work until an expert in blogdown and html comes to our rescue :)

DominiqueMakowski commented 5 years ago

Your feed is back online.

we are back on tracks

humanfactors commented 5 years ago

This should be adjustable in the actual hugo theme without the manual fix. I'll look into this before early next week (ideally this weekend) as I have a fair bit of experience with Hugo — though I admit I have less experience with blogdown. For the record, I am a huge fan of Hugo, so once I have play around most likely can help with technical isssues!

DominiqueMakowski commented 5 years ago

thanks!