easystats / datawizard

Magic potions to clean and transform your data 🧙
https://easystats.github.io/datawizard/
Other
219 stars 16 forks source link

Rename `parameters_skewness` and `parameters_kurtosis` classes #248

Open IndrajeetPatil opened 2 years ago

IndrajeetPatil commented 2 years ago

They were appropriate when these methods used to live in {parameters} package, but not now.

Should we rename them to

strengejacke commented 2 years ago

They are already kurtosis and skewness: https://easystats.github.io/datawizard/reference/skewness.html

IndrajeetPatil commented 2 years ago

I am talking about classes:

Screenshot 2022-09-03 at 20 30 12
strengejacke commented 2 years ago

Ah, ok. If all methods are in datawizard, it should be safe to do so.

IndrajeetPatil commented 2 years ago

Which of the two options do you prefer?

strengejacke commented 2 years ago

I would prefer the one which is more likely to be unique, to avoid conflicts with other packages that have this functions too. Hence I would prefer datawizard_skewness etc