t_to_eta2 vs. t_to_eta2_partial

[DominiqueMakowski]

I am coming back to this because I am still not sure it is the best way to go in terms of clarity.

@mattansb (if I'm understanding you correctly) I understand the importance of stressing that these are partial indices in the sense that they are adjusted for everything else in the model. However, this is very common in all models. I.e, you know that all parameters of a linear regression are "partial" in that sense. Hence it seems unnecessary to add it in all the names, also because the non-partial version does not exist for these function, so no confusion is possible. I.e., IMO, it is sufficient to mention that partial aspect in the documentation since it applies to all functions.

Another bigger issue is that this "partial" could be confused with Partial eta2, partial Omega 2 as they are defined in the ANOVA framework, I.e. as adjusted for the sample size. Thus, if I'm correct that these two partial refer to different things, we should remove the former.

Another possibility could be to group them all under a function like:

F_to_r2(x, method = c("eta2", "omega2", "epsilon2")

@strengejacke

[strengejacke]

Does the function not compute a partial eta square? pls explain

[mattansb]

[mattansb]

As maintainer...............

Just kidding, now that the functions return data frames with named column, I think we can actually close this issue!

library(effectsize)

fit <- lmerTest::lmer(extra ~ group + (1 | ID), sleep)
anova(fit)
#> Type III Analysis of Variance Table with Satterthwaite's method
#>       Sum Sq Mean Sq NumDF DenDF F value   Pr(>F)   
#> group 12.482  12.482     1     9  16.501 0.002833 **
#> ---
#> Signif. codes:  0 '***' 0.001 '**' 0.01 '*' 0.05 '.' 0.1 ' ' 1

F_to_eta2(16.501, 1, 9)
#>   Eta_Sq_partial  CI    CI_low  CI_high
#> 1      0.6470727 0.9 0.2478753 0.812466
F_to_omega2(16.501, 1, 9)
#>   Omega_Sq_partial  CI    CI_low   CI_high
#> 1        0.5849213 0.9 0.1516339 0.7754703
F_to_epsilon2(16.501, 1, 9)
#>   Epsilon_Sq_partial  CI    CI_low   CI_high
#> 1          0.6078585 0.9 0.1643059 0.7916289

^{Created on 2020-03-24 by the reprex package (v0.3.0)}

(Though t_to_r still should be t_to_r_partial, but I'll let that one slide.....)

[DominiqueMakowski]

As maintainer...............

Oh no, what have we done!