search

easystats / insight

:crystal_ball: Easy access to model information for various model objects
https://easystats.github.io/insight/
GNU General Public License v3.0
404 stars 39 forks source link

Reconsider `test-data.frame.R` #884

Open IndrajeetPatil opened 5 months ago

IndrajeetPatil commented 5 months ago

Is this the right name for this test file? I don't see what these tests have anything to do with data frames 🤔

https://github.com/easystats/insight/blob/main/tests/testthat/test-data.frame.R

strengejacke commented 5 months ago

All inputs are data frames?

IndrajeetPatil commented 5 months ago

Ah, I see. The . threw me off because that makes it sound like we are testing data frame S3 method.

I think test-data_frame.R would be better. Would be worthwhile to also (conditionally) test tibbles and data table inputs.