easystats / modelbased

:chart_with_upwards_trend: Estimate effects, contrasts and means based on statistical models
https://easystats.github.io/modelbased/
GNU General Public License v3.0
232 stars 19 forks source link

no warn for upcoming insight::get_data refactor #220

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 1 year ago

Minor changes to tests in order to avoid warnings with this upcoming refactor of the insight::get_data function:

https://github.com/easystats/insight/pull/691

The issue is that we now recover data from the environment, which is much safer in model with transformations. This poses slight problems with testthat, however, since tests are run in weird environments. The tricks are to:

codecov-commenter commented 1 year ago

Codecov Report

Merging #220 (d29c6f4) into main (4e89955) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   36.32%   36.32%           
=======================================
  Files          25       25           
  Lines        1148     1148           
=======================================
  Hits          417      417           
  Misses        731      731           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vincentarelbundock commented 1 year ago

I think this should be merged because the failures are already present in main and are unrelated to this PR.

I don't have merge right on this repo, so I can't do this myself.

IndrajeetPatil commented 1 year ago

Thanks!