easystats / modelbased

:chart_with_upwards_trend: Estimate effects, contrasts and means based on statistical models
https://easystats.github.io/modelbased/
GNU General Public License v3.0
232 stars 19 forks source link

CRAN submission #221

Closed strengejacke closed 1 year ago

strengejacke commented 1 year ago

@DominiqueMakowski for the forthcoming insight update, it would be good to submit modelbased first, to (hopefully) ensure a smooth submission process. Can you push a new release to CRAN?

DominiqueMakowski commented 1 year ago

okay I'll do today

DominiqueMakowski commented 1 year ago

submitted, what about bayestestR / report should I submit too? (sorry I'm been under water)

DominiqueMakowski commented 1 year ago

package modelbased_0.8.5.2.tar.gz does not pass the incoming checks automatically, please see the following pre-tests: Windows: https://win-builder.r-project.org/incoming_pretest/modelbased_0.8.5.2_20230112_025411/Windows/00check.log Status: 1 ERROR, 1 NOTE

DominiqueMakowski commented 1 year ago

it seems like a brms error doesn't it

strengejacke commented 1 year ago

'0.8.5.2'

You submitted a dev-version 🤣

Just increase the version number to something like 0.8.3 and it should work.

DominiqueMakowski commented 1 year ago

🙈

strengejacke commented 1 year ago

submitted, what about bayestestR / report should I submit too? (sorry I'm been under water)

These are not affected by the changes in insight, I think. @vincentarelbundock testet all remaining packages and found no revdep-isuses. But if you feel it's time to submit an update for those as well, just do it. Else, there's no hurry.

DominiqueMakowski commented 1 year ago

I'll submit otherwise all the packages I maintain are trailing behind and it looks bad 😅

DominiqueMakowski commented 1 year ago

package modelbased_0.8.6.tar.gz does not pass the incoming checks automatically, please see the following pre-tests: Windows: https://win-builder.r-project.org/incoming_pretest/modelbased_0.8.6_20230112_080812/Windows/00check.log Status: 1 ERROR, 2 NOTEs

strengejacke commented 1 year ago

hm, strange. Maybe skip this test for now? Honestly, it's really hassling to get stan tests working... Also, https://cranlogs.r-pkg.org/ seems to offline / has moved? we should remove that URL from readme.

strengejacke commented 1 year ago

I have updated the readme... Maybe also send to winbuilder before sending to CRAN? This will catch most of the issues during submission.

IndrajeetPatil commented 1 year ago

cranlogs is back up and running. So you can add the links back in if you want.

IndrajeetPatil commented 1 year ago

We should make sure that we close #216 and #219 before submission, though.

DominiqueMakowski commented 1 year ago

package modelbased_0.8.6.tar.gz is on its way to CRAN.

DominiqueMakowski commented 1 year ago

We should make sure that we close https://github.com/easystats/modelbased/issues/216 and https://github.com/easystats/modelbased/issues/219 before submission, though.