easystats / modelbased

:chart_with_upwards_trend: Estimate effects, contrasts and means based on statistical models
https://easystats.github.io/modelbased/
GNU General Public License v3.0
234 stars 19 forks source link

Rename `at` arguments into `by` #255

Closed strengejacke closed 4 months ago

strengejacke commented 4 months ago

https://github.com/easystats/easystats/issues/404

DominiqueMakowski commented 4 months ago

Thanks Daniel :)

strengejacke commented 4 months ago

I hope all relevant code pieces are updated now. Still some failing checks, due to report, where we also need to make changes. Renaming the arguments throughout all packages will cause some uneasiness when submitting all updates to CRAN, I guess ;-)

strengejacke commented 4 months ago

@DominiqueMakowski The examples I removed in this commit are even not working with the current CRAN version of modelbased - it's not related to this PR.

strengejacke commented 4 months ago

This error occurs when ggplot2 is loaded after poorman (https://github.com/easystats/modelbased/actions/runs/9209112782/job/25332884239):

Caused by error:
! cannot xtfrm data frames
Backtrace:
     ▆
  1. └─... %>% summarise(RT = mean(RT))
  2.   └─base::eval(rhs_call, envir = list(. = lhs), enclos = parent.frame())
  3.     └─base::eval(rhs_call, envir = list(. = lhs), enclos = parent.frame())
  4.       ├─poorman::summarise(., RT = mean(RT))
  5.       └─poorman:::summarise.grouped_df(., RT = mean(RT))
  6.         └─poorman:::groups_set(res, groups[-n], group_by_drop_default(.data))
  7.           └─poorman:::calculate_groups(x, groups, drop)
  8.             ├─...[]
  9.             ├─tibble:::`[.tbl_df`(...)
 10.             ├─base::do.call(...)
 11.             └─base (local) `<fn>`(`<tibble[,1]>`, `<tibble[,1]>`)
 12.               └─base::lapply(z, function(x) if (is.object(x)) as.vector(xtfrm(x)) else x)
 13.                 └─base (local) FUN(X[[i]], ...)
 14.                   ├─base::as.vector(xtfrm(x))
 15.                   ├─base::xtfrm(x)
 16.                   └─base::xtfrm.data.frame(x)
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 59.11330% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 36.39%. Comparing base (b4692b9) to head (ec683fd). Report is 3 commits behind head on main.

:exclamation: Current head ec683fd differs from pull request most recent head aabb649

Please upload reports for the commit aabb649 to get more accurate results.

Files Patch % Lines
R/estimate_slopes.R 16.00% 21 Missing :warning:
R/get_emmeans.R 68.08% 15 Missing :warning:
R/visualisation_recipe.estimate_means.R 0.00% 13 Missing :warning:
R/visualisation_recipe.estimate_slopes.R 0.00% 10 Missing :warning:
R/get_emtrends.R 70.00% 6 Missing :warning:
R/visualisation_matrix.R 0.00% 6 Missing :warning:
R/get_marginaleffects.R 60.00% 4 Missing :warning:
R/estimate_means.R 66.66% 3 Missing :warning:
R/estimate_contrasts.R 92.85% 2 Missing :warning:
R/get_emcontrasts.R 90.47% 2 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ========================================== + Coverage 35.96% 36.39% +0.42% ========================================== Files 25 25 Lines 1190 1220 +30 ========================================== + Hits 428 444 +16 - Misses 762 776 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.