easystats / modelbased

:chart_with_upwards_trend: Estimate effects, contrasts and means based on statistical models
https://easystats.github.io/modelbased/
GNU General Public License v3.0
234 stars 19 forks source link

Check which dev-package are required #257

Closed strengejacke closed 3 months ago

strengejacke commented 4 months ago

insight is on CRAN and breaks modelbased. This PR removes all dev-packages from the REMOTES field, to check which of those packages are required to be on CRAN first, before we submit modelbased.

DominiqueMakowski commented 4 months ago

So I wait

strengejacke commented 4 months ago

Yes, we need to submit datawizard next (i.e. now 😄) @etiennebacher

strengejacke commented 4 months ago

datawizard will also break other packages (well, not break in terms of no longer working, but just deprecation warnings). This was my reply to the "we found rev-dep issues":

Dear CRAN team,

that is expected. In the process of stabilizing the API/user interface for packages from the 'easystats' project, some argument names were renamed, and old names have been deprecated. This will not break downstream dependent packages (in terms of functionality is broken), however, reverse-dependency checks will raise warnings. We have already patched all affected downstream packages and will submit them to CRAN in the next few days, after the release of 'insight'. Once this release-cycle is complete, all warnings due to deprecated argument names should be resolved.

etiennebacher commented 4 months ago

I'm running revdepcheck and will submit when it's done

DominiqueMakowski commented 4 months ago

Please correct before 2024-06-18 to safely retain your package on CRAN.

strengejacke commented 3 months ago

I submitted to win-builder. I don't think we need another package on CRAN before submitting modelbased, so once win-builder checks are ok, we can submit.

strengejacke commented 3 months ago

Any insights from win-builder? @DominiqueMakowski?

jmgirard commented 3 months ago

I assume this warning issue is the same:

library(easystats)
#> # Attaching packages: easystats 0.7.2
#> ✔ bayestestR  0.13.2   ✔ correlation 0.8.4 
#> ✔ datawizard  0.11.0   ✔ effectsize  0.8.8 
#> ✔ insight     0.20.0   ✔ modelbased  0.8.7 
#> ✔ performance 0.11.0   ✔ parameters  0.21.7
#> ✔ report      0.5.8    ✔ see         0.8.4
m <- aov(Sepal.Length ~ Species, data = iris)
estimate_means(m, at = "Species")
#> Warning: Argument `at` is deprecated and will be removed in a future release.
#>   Please use `by` instead.
#> Estimated Marginal Means
#> 
#> Species    | Mean |   SE |       95% CI
#> ---------------------------------------
#> setosa     | 5.01 | 0.07 | [4.86, 5.15]
#> versicolor | 5.94 | 0.07 | [5.79, 6.08]
#> virginica  | 6.59 | 0.07 | [6.44, 6.73]
#> 
#> Marginal means estimated at Species
estimate_means(m, by = "Species")
#> We selected `at = c("Species")`.
#> Warning: Argument `at` is deprecated and will be removed in a future release.
#>   Please use `by` instead.
#> Estimated Marginal Means
#> 
#> Species    | Mean |   SE |       95% CI
#> ---------------------------------------
#> setosa     | 5.01 | 0.07 | [4.86, 5.15]
#> versicolor | 5.94 | 0.07 | [5.79, 6.08]
#> virginica  | 6.59 | 0.07 | [6.44, 6.73]
#> 
#> Marginal means estimated at Species

Created on 2024-06-08 with reprex v2.1.0

strengejacke commented 3 months ago

Yes. After the update round, all warnings should be silenced. And, the funcions' argument names will be more consistent :-) (except data_to_wide(), but that's probably happening in the future, too ;-)

jmgirard commented 3 months ago

Yes. After the update round, all warnings should be silenced. And, the funcions' argument names will be more consistent :-) (except data_to_wide(), but that's probably happening in the future, too ;-)

I am preparing slides for my annual R workshops. Should I teach at or by?

strengejacke commented 3 months ago

Depends on whether your workshop starts, and whether your students/attendees have the latest package versions installed ;-)

We have on CRAN already: insight, datawizard Submitted: performance Submitting the next days: parameters, correlation, modelbased, report (probably see)

The new argument we now use across functions/packages is by (instead of at, group, group_by, split_by etc.).

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.39%. Comparing base (ec683fd) to head (4577fbc). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 36.39% 36.39% ======================================= Files 25 25 Lines 1220 1220 ======================================= Hits 444 444 Misses 776 776 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.