search

easystats / parameters

:bar_chart: Computation and processing of models' parameters
https://easystats.github.io/parameters/
GNU General Public License v3.0
428 stars 36 forks source link

maybe we _do_ need to rename the `effectsize_type` argument to avoid partial matching after all #978

Closed strengejacke closed 3 months ago

strengejacke commented 3 months ago

@strengejacke maybe we do need to rename the effectsize_type argument to avoid partial matching after all (https://github.com/easystats/effectsize/issues/639)...

What would be a good name for this argument? (reminder, it is passed to effectsize(..., type)) (which is only a valid argument for anova objects, htest objects and BFBayesFactor objects - ignored for all other...).

Originally posted by @mattansb in https://github.com/easystats/parameters/issues/975#issuecomment-2147145046

strengejacke commented 3 months ago

Maybe type? type is used for the type of sums of squares.

mattansb commented 3 months ago

Seems too vague given the context model_parameters(..., type = ).

Can we abbreviate? model_parameters(..., es_type = ) (similar to the ci_method argument)

strengejacke commented 3 months ago

yes, sounds good.

strengejacke commented 3 months ago

Mattan, that would mean that you need to prepare an update for effectsize when parameters is submitted.

mattansb commented 3 months ago

I'm ready (: