easystats / parameters

:bar_chart: Computation and processing of models' parameters
https://easystats.github.io/parameters/
GNU General Public License v3.0
416 stars 37 forks source link

[Fix] Fixes edgecase for predict.parameters_efa #980

Closed DominiqueMakowski closed 2 weeks ago

DominiqueMakowski commented 2 weeks ago

Uses only as newdata the needed variables for predicting

strengejacke commented 2 weeks ago

Seems to break tests:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-pca.R:26:3'): principal_components ─────────────────────────────
Error in `data %*% wt`: non-conformable arguments
Backtrace:
    ▆
 1. ├─testthat::expect_identical(...) at test-pca.R:26:3
 2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
 3. │   └─rlang::eval_bare(expr, quo_get_env(quo))
 4. ├─base::nrow(predict(x, newdata = mtcars[1:3, 1:7]))
 5. ├─stats::predict(x, newdata = mtcars[1:3, 1:7])
 6. └─parameters:::predict.parameters_pca(...)
 7.   ├─base::as.data.frame(...) at parameters/R/utils_pca_efa.R:181:5
 8.   ├─stats::predict(...) at parameters/R/utils_pca_efa.R:181:5