search

easystats / performance

:muscle: Models' quality and performance metrics (R2, ICC, LOO, AIC, BF, ...)
https://easystats.github.io/performance/
GNU General Public License v3.0
965 stars 87 forks source link

Remove `pp_check()` alias #706

Closed strengejacke closed 3 months ago

strengejacke commented 3 months ago

Fixes #477

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 16.98113% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 59.83%. Comparing base (846e7cd) to head (dfe08aa). Report is 1 commits behind head on main.

Files Patch % Lines
R/check_predictions.R 16.98% 44 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #706 +/- ## ========================================== - Coverage 60.22% 59.83% -0.39% ========================================== Files 86 86 Lines 6283 6322 +39 ========================================== - Hits 3784 3783 -1 - Misses 2499 2539 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bwiernik commented 3 months ago

Why do we want to remove the aliases? I thought we had resolved the conflicts with pp_check(), and think there is value in exporting methods for that generic?

strengejacke commented 3 months ago

We don't want to remove pp_check(), only posterior_predictive_check() and check_posterior_predictions().