Collect roxygen import tags in a single location

codecov[bot] commented 11 months ago

Codecov Report

Merging #304 (6f72d51) into main (eccd98c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6f72d51 differs from pull request most recent head 14415cd. Consider uploading reports for the commit 14415cd to get more accurate results

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   44.32%   44.32%           
=======================================
  Files          66       66           
  Lines        4742     4742           
=======================================
  Hits         2102     2102           
  Misses       2640     2640

Files Changed	Coverage Δ
R/geom_violindot.R	`40.00% <ø> (ø)`
R/geom_violinhalf.R	`100.00% <ø> (ø)`
R/plot.bayesfactor_parameters.R	`0.00% <ø> (ø)`
R/plot.binned_residuals.R	`0.00% <ø> (ø)`
R/plot.check_collinearity.R	`94.73% <ø> (ø)`
R/plot.check_homogeneity.R	`70.58% <ø> (ø)`
R/plot.check_model.R	`0.00% <ø> (ø)`
R/plot.compare_performance.R	`97.61% <ø> (ø)`
R/plot.estimate_contrasts.R	`97.67% <ø> (ø)`
R/plot.estimate_density.R	`46.87% <ø> (ø)`
... and 10 more

bwiernik commented 11 months ago

I think it's fine to just import ggplot2 once in see, but in general I prefer that any imports be next to the code that actually uses them. We rarely import functions anyway vs namespacing them

IndrajeetPatil commented 11 months ago

We rarely import functions anyway vs namespacing them

Fair enough! Maybe we won't even need to do this for any other repo other than {see}.

easystats / see

Collect roxygen import tags in a single location #304

Codecov Report