search

easystats / see

:art: Visualisation toolbox for beautiful and publication-ready figures
https://easystats.github.io/see/
Other
874 stars 43 forks source link

CRAN submission #320

Closed strengejacke closed 6 months ago

strengejacke commented 7 months ago

@IndrajeetPatil What do you think about submitting a new release to CRAN the next days? I'm planning to submit parameters, but that would break see (nothing to do here, the dev-version of see has already fixed this issue). So we would need to submit both packages within a certain time frame.

IndrajeetPatil commented 7 months ago

Sure, just let the CRAN team know that you’ve informed the maintainer and the update is on the way for broken package. I can then update see once parameters update is on CRAN.

On Fri 2. Feb 2024 at 21:13, Daniel @.***> wrote:

@IndrajeetPatil https://github.com/IndrajeetPatil What do you think about submitting a new release to CRAN the next days? I'm planning to submit parameters, but that would break see (nothing to do here, the dev-version of see has already fixed this issue). So we would need to submit both packages within a week or so.

— Reply to this email directly, view it on GitHub https://github.com/easystats/see/issues/320, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWOHFNIEWCZZF45OLNAQLTYRVCGDAVCNFSM6AAAAABCXHSNJOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTKNZRGQYDCNI . You are receiving this because you were mentioned.Message ID: @.***>

strengejacke commented 7 months ago

Ok parameters is on CRAN

strengejacke commented 7 months ago

We could merge #321 before submission.

strengejacke commented 7 months ago

ok, I think you can submit. I also need to submit a hotfix of parameters due to breaking changes in marginaleffects. Should we submit see first, then parameters hotfix, or other way around?

IndrajeetPatil commented 7 months ago

You can submit the hotfix first, and then I can check see against this version and submit.

strengejacke commented 7 months ago

parameters on CRAN!