search

easystats / see

:art: Visualisation toolbox for beautiful and publication-ready figures
https://easystats.github.io/see/
Other
874 stars 43 forks source link

CRAN RC: 0.8.3 #332

Closed IndrajeetPatil closed 5 months ago

IndrajeetPatil commented 5 months ago

Closes #330

IndrajeetPatil commented 5 months ago

@strengejacke Can you go through the changes in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.57%. Comparing base (bd5b6e1) to head (83e62c4). Report is 2 commits behind head on main.

Files Patch % Lines
R/scale_color_social.R 0.00% 2 Missing :warning:
R/scale_color_bluebrown.R 50.00% 1 Missing :warning:
R/scale_color_metro.R 50.00% 1 Missing :warning:
R/scale_color_pizza.R 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== - Coverage 43.89% 43.57% -0.33% ========================================== Files 67 67 Lines 4882 4909 +27 ========================================== - Hits 2143 2139 -4 - Misses 2739 2770 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

strengejacke commented 5 months ago

@strengejacke Can you go through the changes in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

Maybe we can revert that? Points looked too big in check_model(), but rather small in single plots.

strengejacke commented 5 months ago

Would you say it's ok now, or increase dot size even more?

IndrajeetPatil commented 5 months ago

Would you say it's ok now, or increase dot size even more?

Yes, looks much better now!