search

easystats / see

:art: Visualisation toolbox for beautiful and publication-ready figures
https://easystats.github.io/see/
Other
874 stars 43 forks source link

Fix return class of check_model() patchwork #339

Closed bwiernik closed 4 months ago

bwiernik commented 4 months ago

Closes https://github.com/easystats/performance/issues/712

bwiernik commented 4 months ago

The R CMD Checks look good--not sure about the other workflows

bwiernik commented 4 months ago

@strengejacke the issue was that apparently invisible() doesn't also return unless it's the last line of the function and gets the implicit return. I didn't realize that

strengejacke commented 4 months ago

The R CMD Checks look good--not sure about the other workflows

I think you can ignore the other workflows. They error due to warnings which are hard to silence. @IndrajeetPatil do you have any ideas how to handle the failing workflows?

IndrajeetPatil commented 4 months ago

We just need to fix the new warnings generated by ggplot2 3.5.0; I am waiting for ggplot2 3.5.1, which would silence some of these warnings.