Closed etiennebacher closed 1 year ago
We can try with this. I had adapted this action from here, and they don't do git add
either.
Let's see if it works: https://github.com/easystats/easystats/runs/8152895788?check_suite_focus=true
We can try with this. I had adapted this action from here, and they don't do
git add
either.
They don't do "git add" because they put the new markdown file in "git commit" whereas we don't:
Gotcha!
I don't think this is going to work because when we knit the README.Rmd, it typically produces changes to also included plots, etc., and we are committing only the .md
file. So, even if this were to work, all side effects produced during rendering will be out of date.
So should we use "git add ." instead?
We can try. It will work, but we should just make sure that nothing that we are not creating isn't committed (e.g. /renv
folder created by GHA).
Let's check with the new one: https://github.com/easystats/easystats/runs/8153333877?check_suite_focus=true
I tested locally and "git add man/figures/*.png README.md" correctly captures new png in man/figures and the new readme. Are there other special files that are modified in general?
Okay, let's use this more specific approach.
I am trying it here: https://github.com/easystats/easystats/runs/8153418094?check_suite_focus=true
All these tests have to fail because easystats/easystats
doesn't use the workflows from easystats/workflows
😅
NOOOOOOOO LMAO, so dumb
I can update the GHA in easystats/easystats
hum, easystats needs a lot of extra packages in the readme (deepdep, miniCRAN, etc.). Maybe we can let the render-readme GHA as before and just add the fix with "git add" there?
I agree. easystats will need to be dealt differently for render README workflow.
Done
Ok so we can add files but the commit cannot be pushed automatically because the branch "main" is protected:
https://github.com/easystats/easystats/runs/8154484139?check_suite_focus=true#step:8:19
Related to https://github.com/easystats/easystats/issues/278. The GHA renders the README but doesn't commit the change, maybe this is why it isn't automatically updated?