search

easystats / workflows

GitHub Actions for {easystats} packages
https://indrajeetpatil.github.io/preventive-r-package-care
Creative Commons Zero v1.0 Universal
9 stars 1 forks source link

Why is `check-readme` workflow failing? #32

Closed IndrajeetPatil closed 1 year ago

IndrajeetPatil commented 1 year ago

Haven't looked closely at it, but I am fairly certain that there is a circularity in the development versions needed.

E.g. parameters requires devel-see, while devel-see requires devel-parameters, so a new installation process starts while the previous installation task is in progress.

strengejacke commented 1 year ago

I have checked all new features so far across dev versions, so I can remove remotes from DESCRIPTION. I plan to start submitting updates today or tomorrow, starting with insight.

IndrajeetPatil commented 1 year ago

There is nothing wrong with this workflow. E.g. it works just fine for easystats.

I think once we make new releases and remove circular devel-dependencies, this issue will fix itself.

IndrajeetPatil commented 1 year ago

@strengejacke We can now have circular deps, and it shouldn't cause any problems for our workflows (cf. https://github.com/r-lib/pkgdepends/commit/5787a54cda03b40b8e06f3f5cbf40e6c14b48944).

strengejacke commented 1 year ago

That's cool! Helpful to coordinate changes across packages that might cause (rev-)dep issues among our dev-versions. :-)

IndrajeetPatil commented 1 year ago

True. But this will start working only from tomorrow. The pak binaries are updated at night.