search

easystats / workflows

GitHub Actions for {easystats} packages
https://indrajeetpatil.github.io/preventive-r-package-care
Creative Commons Zero v1.0 Universal
8 stars 1 forks source link

`revdepcheck` action doesn't work? #33

Open etiennebacher opened 1 year ago

etiennebacher commented 1 year ago

Cf https://github.com/easystats/datawizard/pull/385

IndrajeetPatil commented 1 year ago

I think https://github.com/easystats/performance/issues/556 can be a good testing ground for this.

Right now, if we run revdepcheck on parameters, performance breakage should show up.

etiennebacher commented 1 year ago

All revdep checks pass: https://github.com/easystats/parameters/actions/runs/4494885631/jobs/7907926195?pr=859

Looks like there's sth wrong here

IndrajeetPatil commented 1 year ago

Yeah, but it's not clear to me if the tests are comparable across CRAN and GitHub versions of performance in terms of their reliance on parameters.

I am going to make an extremely breaking change (like removing an export) and then check again. If that doesn't break anything then, yes, this workflow is not working as expected.

IndrajeetPatil commented 1 year ago

Yeah, definitely this workflow is not working. I don't understand why, though. It's the same code one runs locally.

IndrajeetPatil commented 6 months ago

@easystats/maintainers Just FYI: in case you are thinking of using the revdepcheck, that workflow is currently not working. You will need to either run it locally yourself or wait for CRAN to run it after submission.

strengejacke commented 6 months ago

Thanks, I usually also run local revdep checks