search

easystats / workflows

GitHub Actions for {easystats} packages
https://indrajeetpatil.github.io/preventive-r-package-care
Creative Commons Zero v1.0 Universal
9 stars 1 forks source link

A few packages take a long time to be built #37

Closed etiennebacher closed 2 months ago

etiennebacher commented 1 year ago

Installing Matrix, TMB, mmrm and glmmTMB from source takes a long time (e.g 12 min on this run: https://github.com/easystats/datawizard/actions/runs/5086704825/jobs/9141410955)

Maybe I missed something but why can't we install the binaries instead of building from source?

strengejacke commented 1 year ago

I think we did this because glmmTMB (and/or TMB) complain about incompatible Matrix version (TMB was built with version, but you need version...) and this is resolved after installing from source. See https://rdrr.io/cran/glmmTMB/man/reinstalling.html

etiennebacher commented 1 year ago

But it looks like this was resolved (https://github.com/glmmTMB/glmmTMB/issues/276). Do we keep this because it actually fails or just in case there are more inconsistencies in the future?

Dividing the GHA time by 2 would be nice

strengejacke commented 1 year ago

I don't think it's resolved. I still see this issue when installing a new R version. Tagging @bbolker

IndrajeetPatil commented 2 months ago

This is really driving me nuts.

Now that R 4.4 is out today, I wouldn't mind bumping the minimum needed R version to 4.0, and get rid of the installation from source for some packages.