search

eatdrinkhealthy / edh-app

The Eat Drink Healthy web (and tentatively mobile / cordova) app created with Meteor and React.
0 stars 0 forks source link

Filters branch, adding jest & stage-0 #12

Closed stevenjmarsh closed 7 years ago

stevenjmarsh commented 7 years ago

@johnthepink please take a look at this pull request.

[NOTE: this branch was branched off of the 'filters' branch. both are quite ahead of master]

In filters-jest... I have added stage-0. I tested using the object spread operator in both the source code and jest tests (have removed the examples since).

Also, I have added the jest packages, some meteor mocks (tests), and some simple tests for the Filter component.

Feel free to provide feedback on code, practices, process. Or we can do an online review if that is more effective. eg,

Thanks. I'm open weekends and evenings now too. Steve.

johnthepink commented 7 years ago

@stevenjmarsh awesome! I will take a look Monday or Tuesday.

stevenjmarsh commented 7 years ago

Cool. Would you have time one night this week to pair and implement a small piece of functionality? I’ll create a card for it in the github project. But in short, it would be to capture a list of search criteria from an existing filter component, and apply it to an existing map component. A lot of the pieces are already in place, and are pretty small / light. But are not tied together since converting to react.

Thanks. Steve.

On Jan 22, 2017, at 8:42 PM, John Pinkerton notifications@github.com wrote:

@stevenjmarsh https://github.com/stevenjmarsh awesome! I will take a look Monday or Tuesday.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eatdrinkhealthy/edh-app/pull/12#issuecomment-274378616, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6kT9LM-7LJuq6BMCqp5J6QK8GlA4tzks5rVAWSgaJpZM4Lp3cv.

johnthepink commented 7 years ago

@stevenjmarsh sure! How does Thursday sound?

stevenjmarsh commented 7 years ago

@johnthepink , shoot I just had an event pop up after work Thursday. I am not sure when it will end, I should know later today. As soon as I find out, will let you know.

other options, tonight anytime, Wednesday after 8:30pm. Thursday TBD, Friday anytime. Or, any afternoon/evening over the weekend or next week.

stevenjmarsh commented 7 years ago

closing this branch, check out filters-jest-yarn-storybook branch instead