search

eatgrass / obsidian-pomodoro-timer

A pomodoro timer that helps manage your daily focus
MIT License
93 stars 5 forks source link

Enable/disable sound notification setting #2

Closed vaygr closed 6 months ago

vaygr commented 6 months ago

It would be great to have a slider to turn on/off sound notifications. And also to choose a custom sound to play.

eatgrass commented 6 months ago

yeah, please upgrade to the latest release https://github.com/eatgrass/obsidian-pomodoro-timer/releases/tag/1.0.6

vaygr commented 6 months ago

Excellent, thanks a lot!

What if turning off notification sound would also hide custom sound setting?

eatgrass commented 6 months ago

Hi @vaygr

What if turning off notification sound would also hide custom sound setting?

If you turn off the notification sound, it simply mutes all notifications. no matter if you've got a custom sound set up or not.

vaygr commented 6 months ago

Yeah, I understand. That's just to make settings page look neater. Similar to what happens to logging when you set it to None.

eatgrass commented 6 months ago

Thanks, that's a good suggestion, will do it in the next release