search

eavanvalkenburg / pysiaalarm

A python package to connect to a SIA DC-09 based alarm system.
MIT License
37 stars 30 forks source link

Quirks to support egardia / woonveilig alarm systems #27

Closed robvolgers closed 1 year ago

robvolgers commented 2 years ago

This alarm system has two specific quirks which pysiaalarm has to be aware of to work properly: it needs to support messages where the CRC is in binary instead of hexadecimal, and it needs to support devices which have timestamps in local time instead of UTC.

I've seen the "binary CRC" thing mentioned online for some other alarm systems, so it doesn't seem to be unique to this specific brand. I'm not sure if other systems exist that also use non-UTC time.

The commit messages should be pretty self-explanatory. Please check the message for the binary CRC commit to see some comments about why a server setting is necessary, and how it could possibly be avoided with some changes to error handling.

The binary CRC commit also has an unrelated correctness fix for responses, as noted in the commit message.

eavanvalkenburg commented 2 years ago

Oh and could you PR to the dev branch?

eavanvalkenburg commented 2 years ago

Also, just had the Actions run, and apparently the test where not adapted!

eavanvalkenburg commented 1 year ago

Hi @robvolgers I finally got around to doing some work on this package, I have added support for the device timezone in the account (in the dev branch), have done that based on pytz timezones, with a default on UTC. Please have a look. I will look at the binary stuff as well.

eavanvalkenburg commented 1 year ago

Just created a release with these features, 3.1.0b1, check it out @robvolgers