search

eayus / sddm-theme-clairvoyance

An SDDM theme
GNU General Public License v3.0
71 stars 14 forks source link

High DPI Session names overlapping #5

Closed vKnmnn closed 7 years ago

vKnmnn commented 7 years ago

Hi there!

You have made a very nice theme, thank you!

I notice that my users sessions are all garbled up in the menu, wheter I enable HiDPI or set it off in sddm.conf

sddm-greeter --test does it right , but scales way too much

What can i try to resolve this behaviour?

eayus commented 7 years ago

Hi, unofortunately the highest resolution screen I have is 1920x1080, so I can't test if these fixes work. My guess is the HiDPI mode is scaling up the fonts, and they wont fit in the harcoded sized invisible 'box' around them. I think your best bet is to increase the height and width of the box. To do this edit the 'width' and 'height' properties on lines 42 and 43 respectively in Main.qml. When I get a chance I will edit the theme to detect if it in HiDPI mode and automatically change properties like this. Hope this fixes your problem.

vKnmnn commented 7 years ago

i increased the width to 285, left height at 50, and reduced font size to 10. now i3 (with debug log) fits in there as it should. Font size 12 would have needed at least 400 width and looked to big.

Thanks for the help!

vKnmnn commented 7 years ago

looking at the video again, not changing the boxes at all, but decreasing Font size to 6 fits the original better. So i tried out halving all the font sizes, and now it looks like the original. this seems to be a font-scaling issue indeed. I also noticed you use Fira Font but don't list it as a dep anywhere.

eayus commented 7 years ago

Hi, glad you managed to solve your problem. I am currently doing some code refactoring and I will add an option in theme.conf for HPDI which you can set to automatically set the font sizes to 6. Nice spot on the dependency, I'll add that to the README.

eayus commented 7 years ago

I've added the option in theme.conf, just set enableHDPI=true in theme.conf (after updating to the latest version). If you have any other scaling issues on HDPI don't be afraid to open an issue, as I can't test it myself.

vKnmnn commented 7 years ago

All seems fine now, HDPI on or off both delivers non-overlapping textfields although i feel, that scaling isn't correct, because everything's too big. It's ok though greeter

eayus commented 7 years ago

I'm assuming SDDM/Qt is just automatically scaling everything up by integer values, so it will either look too big or too small. Aside from scaling everything up manually, I don't think there is an easy fix.