Incorporate a fork's changes (possibly to libhoney-rust)

eaze / tracing-honeycomb

Fork of https://github.com/inanna-malick/tracing-honeycomb

MIT License

17 stars 19 forks source link

Incorporate a fork's changes (possibly to libhoney-rust) #9

Open jrouaix opened 3 years ago

jrouaix commented 3 years ago

Hello, thank you folks for this lib !

I had 1 out of 3 distinct environments where it didn't work as expected :

nothing received to honeycomb
some "memory leak" (symptom of the send queue growing)

Today I tried the fork https://github.com/agrinman/tracing-honeycomb from @agrinman, my problem is solved !

Any plan to PR/Merge ?

agrinman commented 3 years ago

Hey there, yeah I had the same issue. My fork uses one runtime and async io everywhere instead of crossbeam. I'm not positive that it's 100% correct but it's been working for me fairly well for several weeks. I'll open a PR for it.

agrinman commented 3 years ago

Worth noting that the primary changes are actually here: https://github.com/agrinman/libhoney-rust

Fishrock123 commented 3 years ago

@agrinman are those changes upstream-able? Did you make any toher changes in your fork of this repository? (And were those changes pre 0.3? i.e. from Inanna's repo?)

Fishrock123 commented 3 years ago

@jrouaix Do you have any additional information? The channel side may grow but will be capped at 10k entries, and won't deadlock as of 0.3.

I'm not sure about your first issue, did you possibly set sampling or something else?

Fishrock123 commented 3 years ago

@agrinman Could you please make a draft PR to libhoney to see if those changes might be acceptable there?

jrouaix commented 2 years ago

Tried to update to the latest

tracing-subscriber = "0.3"
tracing-honeycomb = "0.4.3"
libhoney-rust = "0.1.6"

This behavior remained the same.