search

ebaauw / homebridge-rpi

Homebridge plugin for Raspberry Pi.
Apache License 2.0
309 stars 19 forks source link

Add wiki link to info text for USB power #120

Closed andypiper closed 2 years ago

andypiper commented 2 years ago

I noticed that when you added the USB power option, there was a missing link to the Wiki.

This pull request adds that link and expands the information text.

For consistency, it also capitalises Homebridge, and replaces "Lightbulb" with "Light", in a couple of other informational messages.

ebaauw commented 2 years ago

Thanks.

Looks like I screwed up the indentation as well. What JSON linter are you using? I though I'd setup Atom to check JSON files as well, but apparently this fails to check the layout.

I noticed that when you added the USB power option, there was a missing link to the Wiki.

Oops.

For consistency, it also capitalises Homebridge

Thanks. I've been using Homebridge for too long, from back when it was still spelled "homebridge".

and replaces "Lightbulb" with "Light"

Not happy with that; the HomeKit service is called "Lightbulb". You'd need to submit a PR to Apple to change that ;-)

andypiper commented 2 years ago

Ah, in the Light/Lightbulb controversy, I’ll defer to Apple.

I’m using VSCode and it has its own JSON linter/formatter, I think. I hadn’t even noticed that it had done anything until I submitted the PR…!

ebaauw commented 2 years ago

I already installed the eslint-jsonlint package in Atom, but that doesn't seem to do anything with the layout. Now installed jsonlint and ran that manually on the JSON files of all my plugins. Found more discrepancies than I would care to admit...