ebaauw / homebridge-ws

Homebridege plugin for virtual weather station
Apache License 2.0
106 stars 4 forks source link

[Feature request] Rename possibility of the accesory #44

Closed sanderrobbers closed 2 years ago

sanderrobbers commented 2 years ago

Now the accesory are in the english language stated in the code itself

this.wsServices.temperature.characteristicDelegate('temperature'),
this.wsServices.humidity.characteristicDelegate('humidity'),
this.wsServices.pressure.characteristicDelegate('pressure')

It will be nice to have a rename possibility

ebaauw commented 2 years ago

I don't understand what you're asking. Accessory names can be changed from HomeKit. The code you're showing concerns internal variable names, that are not visible to the HomeKit user and appear only in the debug log messages. I'm not going to support localisation of log messages.

Note that the HomeKit accessory protocol doesn't support localisation, as this is (should be) handled by the HomeKit application. E.g. the Current Temperature characteristic always reports the temperature in °C; it's up to the HomeKit app to convert that to °F, when desired by the user. Similarly, characteristic types are identified by UUID, it's up to the HomeKit app to translate that Into a (local language) name. That's why you actually see different HomeKit apps using different names for the same characteristic type: e.g. On vs Power.

sanderrobbers commented 2 years ago

Oh, i get it, so I will rename to my own localization within homebridge "Accessoires". And also rename it to the same in the Homekit application.

Currently I am seeing:

Location Humidity Location Temperature Location Weather

ebaauw commented 2 years ago

These are the service names. You can update them from any HomeKit app, and they sync to all your devices and apps. The Homebridge UI is not a proper HomeKit app, but I think you should be able to rename the tiles there as well. Not sure, as I don’t use the Accessories feature of the UI.