ebadi / OpenScenarioEditor

ASAM Open Scenario Editor
BSD 3-Clause "New" or "Revised" License
141 stars 19 forks source link

make -j4 install I think is bound to gcc. Perhaps that's the problem? #7

Open JinxBIGBIG opened 3 years ago

JinxBIGBIG commented 3 years ago

make -j4 install I think is bound to gcc. Perhaps that's the problem? More generic way would be: cmake --build . -j 4 --target install But the -j (parallel builds) was introduced in 3.11, so if you're running an older cmake, either update it or simply remove -j, like this: cmake --build . --target install

Originally posted by @eknabevcc in https://github.com/ebadi/OpenScenarioEditor/issues/6#issuecomment-853605423

JinxBIGBIG commented 3 years ago

Thank you for your answer.I have tried the method above and still failed.Did you have ran the OpenScenarioEditor successfully?some problems about the "include<>" files happend.

ebadi commented 3 years ago

Hello @JinxBIGBIG, Thanks for reporting this issue.

Please remove OpenScenario directory and follow the build instruction and PLEASE also include the commands that you are entering in the terminal and their result. (please attach this as a txt file)

JinxBIGBIG commented 3 years ago

HI @ebadi . Thanks for your response.Well,I enter the terminal under the "OpenScenarioEditor/run.sh" root folder and run the commands like this: ./run.sh The result goes to like this **fatal error: utils/geom/PositionVector.h: No such file or directory

include <utils/geom/PositionVector.h> compilation terminated.**

ebadi commented 3 years ago

Thanks @JinxBIGBIG , Unfortunately, This is not enough for me to detect the problem. I would appreciate if you attach the FULL terminal log from the very initial step. (Please remove OpenScenario directory first) Thanks.

xfqbuaa commented 2 years ago

same error

include <osg/PositionAttitudeTransform>

ebadi commented 2 years ago

Hello @xfqbuaa Thanks for reporting this issue.

Please remove OpenScenario directory and follow the build instruction and PLEASE also include the commands that you are entering in the terminal and their result. (please attach this as a txt file)

xfqbuaa commented 2 years ago

I have followed your instructions and find the error place mainly in build.sh in pyesmini folers. cd ~ rm -rf ~/OpenScenarioEditor git clone https://github.com/ebadi/OpenScenarioEditor ~/OpenScenarioEditor > ~/log0.txt cd ~/OpenScenarioEditor sudo apt install git python3-pip python3-pyqt5 ; pip3 install PyQt5 > ~/log1.txt git clone https://github.com/ebadi/pyesmini pyesmini > ~/log2.txt cd pyesmini ; ./build.sh > ~/log3.txt cd ~ python3 OpenScenarioEditor.py > ~/log4.txt

1, the tag should be ec2f3e7256c97d32b1a97f0cb8b9bf7f5085bc7e, shown in this issue 2, there is a error will stop make install process when make -j4 install

[ 1%] Generating ../../../../EnvironmentSimulator/Modules/CommonMini/_version.cpp, ../../../../EnvironmentSimulator/Modules/CommonMini/version.cpp Scanning dependencies of target CommonMini [ 1%] Generating ../../../../EnvironmentSimulator/Modules/CommonMini/_version.cpp, ../../../../EnvironmentSimulator/Modules/CommonMini/version.cpp [ 2%] Building CXX object EnvironmentSimulator/Modules/CommonMini/CMakeFiles/CommonMini.dir/version.cpp.o [ 4%] Linking CXX static library libCommonMini.a /usr/bin/ar qc libCommonMini.a CMakeFiles/CommonMini.dir/CommonMini.cpp.o CMakeFiles/CommonMini.dir/version.cpp.o CMakeFiles/CommonMini.dir/buildnr.cpp.o /usr/bin/ranlib libCommonMini.a [ 7%] Built target CommonMini [ 8%] Building CXX object EnvironmentSimulator/Modules/Controllers/CMakeFiles/Controllers.dir/ControllerSumo.cpp.o /home/xufq/Downloads/OpenScenarioEditor/pyesmini/esmini/EnvironmentSimulator/Modules/Controllers/ControllerSumo.cpp:19:10: fatal error: utils/geom/PositionVector.h: No such file or directory 19 | #include <utils/geom/PositionVector.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [EnvironmentSimulator/Modules/Controllers/CMakeFiles/Controllers.dir/build.make:131: EnvironmentSimulator/Modules/Controllers/CMakeFiles/Controllers.dir/ControllerSumo.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:420: EnvironmentSimulator/Modules/Controllers/CMakeFiles/Controllers.dir/all] Error 2 make: *** [Makefile:130: all] Error 2

This is also why someone can open ui while crash when open xosc files and missing libesminiLib.so.

I have successfully built esmini latest version following esmini document The esmini installation instructions also does not work here for version esmini 2.1.5. Can your codes be compatible for esmini latest version?

xfqbuaa commented 2 years ago

A clear error message for information: home/xufq/Downloads/OpenScenarioEditor/pyesmini/esmini/EnvironmentSimulator/Modules/Controllers/ControllerSumo.cpp:19:10: fatal error: utils/geom/PositionVector.h: No such file or directory 19 | #include <utils/geom/PositionVector.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

xfqbuaa commented 2 years ago

I found similar issues and also a link The main problem is because network and didn't download necessary zip package and lead to compile error.

Where can I change to only compile while not download package if I manually download these files? I didn't find CMakeLists.txt definition. Thanks a lot.

xfqbuaa commented 2 years ago

I finally made it works and a short summary: The root reason for missing something due to download fail.

cd ~ rm -rf ~/OpenScenarioEditor git clone https://github.com/ebadi/OpenScenarioEditor cd ~/OpenScenarioEditor sudo apt install git python3-pip python3-pyqt5 ; pip3 install PyQt5 git clone https://github.com/ebadi/pyesmini pyesmini cd pyesmini git clone https://github.com/esmini/esmini.git esmini cd esmini git checkout ec2f3e7256c97d32b1a97f0cb8b9bf7f5085bc7e # 1st Feb 2021 = esmini 2.1.5 (build 1108) mkdir build cd build

manually download googletest, OpenSceneGraph, OSI, SUMO unzip to ./esmini/externals modify ./esimini/EnvironmentSimulator/CMakeLists.txt and comment download code. check ./esmini/externals/pugixml, if not copy or download check ./esmini/resources/models, if not copy or download

cmake ../ -DUSE_OSG=true -DCMAKE_BUILD_TYPE=Release make -j4 install cd ../../ cp ./esmini/build/EnvironmentSimulator/Libraries/esminiRMLib/libesminiRMLib.so pyesmini/libesminiRMLib.so cp ./esmini/build/EnvironmentSimulator/Libraries/esminiLib/libesminiLib.so pyesmini/libesminiLib.so cp -r esmini/resources/ . python3 tests/pyesmini_tests.py python3 tests/pyesminiRM_tests.py cd ~ python3 OpenScenarioEditor.py

lily410 commented 1 year ago

I finally made it works and a short summary: The root reason for missing something due to download fail.

cd ~ rm -rf ~/OpenScenarioEditor git clone https://github.com/ebadi/OpenScenarioEditor cd ~/OpenScenarioEditor sudo apt install git python3-pip python3-pyqt5 ; pip3 install PyQt5 git clone https://github.com/ebadi/pyesmini pyesmini cd pyesmini git clone https://github.com/esmini/esmini.git esmini cd esmini git checkout ec2f3e7256c97d32b1a97f0cb8b9bf7f5085bc7e # 1st Feb 2021 = esmini 2.1.5 (build 1108) mkdir build cd build

manually download googletest, OpenSceneGraph, OSI, SUMO unzip to ./esmini/externals modify ./esimini/EnvironmentSimulator/CMakeLists.txt and comment download code. check ./esmini/externals/pugixml, if not copy or download check ./esmini/resources/models, if not copy or download

cmake ../ -DUSE_OSG=true -DCMAKE_BUILD_TYPE=Release make -j4 install cd ../../ cp ./esmini/build/EnvironmentSimulator/Libraries/esminiRMLib/libesminiRMLib.so pyesmini/libesminiRMLib.so cp ./esmini/build/EnvironmentSimulator/Libraries/esminiLib/libesminiLib.so pyesmini/libesminiLib.so cp -r esmini/resources/ . python3 tests/pyesmini_tests.py python3 tests/pyesminiRM_tests.py cd ~ python3 OpenScenarioEditor.py

hello, how can i download googletest, OpenSceneGraph, OSI, SUMO?Could you please explain it in more detail?thanks a lot!

eknabevcc commented 1 year ago

Normally the external file packages should be downloaded automatically when the cmake .. script is run from esmini/build folder. I'm not sure in the case of this project, maybe it will indirectly run cmake for esmini?

Anyway, if the files are missing they can be downloaded manually. You should be able to use the links in the following file: https://github.com/esmini/esmini/blob/master/support/cmake/cloud/esmini.cmake

For OSI, recommendation is to use the 3.5.0 version. (osi_3_5_0)