ebanalyse / NERDA

Framework for fine-tuning pretrained transformers for Named-Entity Recognition (NER) tasks
MIT License
153 stars 35 forks source link

Wrong scikit-learn dependency causes issues. #46

Open sorenmc opened 1 year ago

sorenmc commented 1 year ago

We are using NERDA for a couple things, but we currently get this error using NERDA as a dependency.

× python setup.py egg_info did not run successfully.
    │ exit code: 1
    ╰─> [18 lines of output]
        The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
        rather than 'sklearn' for pip commands.

        Here is how to fix this error in the main use cases:
        - use 'pip install scikit-learn' rather than 'pip install sklearn'
        - replace 'sklearn' by 'scikit-learn' in your pip requirements files
          (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
        - if the 'sklearn' package is used by one of your dependencies,
          it would be great if you take some time to track which package uses
          'sklearn' instead of 'scikit-learn' and report it to their issue tracker
        - as a last resort, set the environment variable
          SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error

The issue stems from adding the deprecated sklearn instead of scikit-learn in your setup file at line 21:

https://github.com/ebanalyse/NERDA/blob/ae45d7e5368059721d1073384201433ea7a6e820/setup.py#L21

Would you please change the dependency to scikit-learn instead

azizhish commented 3 months ago

Hi, I am still getting this issue when running pip3 install nerda