search

ebarnard / rust-plist

A rusty plist parser.
MIT License
71 stars 42 forks source link

Update to quick-xml 0.27.0 #101

Closed cmyr closed 1 year ago

cmyr commented 1 year ago

This has one somewhat-annoying change: io::Errors that are generated by quick-xml are now wrapped in an Arc, which ends up polluting our own error type, and is a (minorly) breaking API change. I'm not sure if there is a better approach...

ebarnard commented 1 year ago

Does Arc::try_unwrap work? Presumably quick-xml isn't holding onto another reference to the Arc.

If that doesn't work we could try Error::raw_os_error + Error::from_os_error and fall back to Error::from(err.kind()) as a last resort.

cmyr commented 1 year ago

cool that makes more sense. I've gone with try_unwrap and then falling back to from(kind).