Fix clippy lints in tests

ebarnard / rust-plist

A rusty plist parser.

MIT License

71 stars 42 forks source link

Fix clippy lints in tests #141

Closed alpha-tango-kilo closed 3 months ago

alpha-tango-kilo commented 5 months ago

Something I noticed while working on #140 when I wanted to make sure the macro invocations weren't producing lints. For the unaware, clippy doesn't check code in #[cfg(test)] by default unless you pass the --tests flag, at which point I noticed several errors in existing code

I also noticed that clippy isn't being run as part of the GitHub workflow, which I could add as part of the lint job if you'd like :)

ebarnard commented 3 months ago

Happy to merge as is, but also happy to add clippy to the lint job as well. Up to you.

alpha-tango-kilo commented 3 months ago

I'd merge this for now, and I'll maybe get to the CI tweak at the weekend (no reason why it can't be a seperate PR), cheers!