search

ebarnard / rust-plist

A rusty plist parser.
MIT License
71 stars 42 forks source link

Convert types to and from `Value`s using serde #85

Closed ebarnard closed 1 year ago

ebarnard commented 2 years ago

Closes #79.

ebarnard commented 1 year ago

@jcgruenhage Sorry, I completely missed the notification for this. I'm quite busy at the moment so might take a while to get round to doing things, but very happy to get lots of notifications.

Thanks for the rebase. I seem to remember this was nearly finished. Will try and have another look tomorrow to see if I can remember what the last things to finish up were.

jcgruenhage commented 1 year ago

Don't worry about stuff taking a bit. Since my first version of the osquery Void extension is finished and works as expected, improving this crate further is less of a priority for me right now. Both this PR as well as the error message improvement issue will be interesting for me when I continue on that extension and use structs instead of the Value type, but since the MVP exists and is running smoothly, other work has taken priority for me right now.

epilys commented 1 year ago

@jcgruenhage could you merge this since you fixed the doc issues in your code review? If it cannot rebase without conflicts I am willing to do that. (I need this feature)

amsam0 commented 1 year ago

Is there anything stopping this PR from being merged?

ebarnard commented 1 year ago

@naturecodevoid Absolutely nothing, I've just been busy and forgot about it.