search

ebarrenechea / header-decor

A couple of sticky header decorations for android's recycler view.
Apache License 2.0
878 stars 159 forks source link

Switched paramterets in getHeaderTop #23

Closed lhoracek closed 8 years ago

lhoracek commented 9 years ago

You have switched parameters in getHeaderTop method in DoubleHeaderDecoration. Calling it with subHeader, header as params, but method expects exactly opposit order (header, subHeader) looks like it works by mistake :-)

ebarrenechea commented 9 years ago

@lhoracek thanks for pointing that out! It's been a while since I touched that code, but I'll have a look and sort out any issues. :+1:

ebarrenechea commented 8 years ago

@lhoracek I just realized I never got back to you on this. It was a mistake to switch header and subheaders there! The code only works because all it cares about is the x coordinate and height of both the header and subheader (we're trying to find where it should go) so the order of the things doesn't really matter. I've fixed it along with a few other changes that I'm currently working on. Thanks once again! :)