Closed gelbertgel closed 6 years ago
I think there is a problem with jitpack build so it is not downloadable from jitpack. ca.barrenechea.header-decor:header-decor:0.2.8
works for me so you can also use this until a new version is released to jitpack.
As I mentioned there is a problem at jitpack build system. https://github.com/jitpack/jitpack.io/issues/2837 .I have added a badge for jitpack so we will be able to see problems like this easier.
Should be working now I think
It is still broken. I think jitpack will not be able to build it with the old build tools. A release needs to be made.
I used another jitpack project. It's built without error but this project didn't build in gradle.
@eduardobarrenechea @starkej2 should we do another release to fix this problem?
Fine with me, but someone should probably test all of the changes since the last release first to make sure nothing got broken.
I can do it over the weekend. how was the testing done previously?
I just tested with the sample app, as most of the functionality was easily observable through manual testing. We should think about getting a few unit tests in place to make sure things are behaving as expected.
Another thing that just occurred to me is that we can release a -SNAPSHOT
version of the library to test if the jitpack issue has been addressed. We should look into how to make it happen as I'm guessing jitpack should have some documentation on how to set it up.
actually we don't need to do anything. jitpack does itself. implementation 'com.github.edubarr:header-decor:master-SNAPSHOT'
should work out of the box.
Thank you it is resolved!
When I add this to gradle, it fails:
Failed to resolve: com.github.edubarr
My project build.gradle:
My app build gradle: