search

ebarrenechea / header-decor

A couple of sticky header decorations for android's recycler view.
Apache License 2.0
879 stars 159 forks source link

changed order of the maven repos #94

Closed oshamahue closed 6 years ago

oshamahue commented 6 years ago

please review the pr to fix: https://github.com/edubarr/header-decor/issues/91

oshamahue commented 6 years ago

https://jitpack.io/#edubarr/header-decor/jitpack_fix-SNAPSHOT it seems jitpack could build this.

starkej2 commented 6 years ago

The badge is still red on the jitpack_fix branch. Doesn't that mean it failed? screen shot 2018-06-12 at 12 11 59 pm

oshamahue commented 6 years ago

No it is for latest tagged version. After the pr is completed we can tag the master as 0.2.9 and it will be released at jitpack as a version and badge will be updated. You can check the build status of the versions, branches and commits here https://jitpack.io/#edubarr/header-decor

starkej2 commented 6 years ago

👍 Ah ok. Why does changing the order of the gradle repositories fix the issue? What was the root cause @oshamahue?

oshamahue commented 6 years ago

0.2.8 was failing because there were no google maven repo configured. But latest master branch was also failing which includes google as repo. At the build gradle checks the repos with the given order for a dependency. jcenter started to mirror Google repo. I think there could be an issue with jcenter on the mirrored dependencies so it was failing to resolve some google library. But not %100 sure what is the problem with jcenter.

starkej2 commented 6 years ago

It might have been a temporary outage. Everything seems to be working okay now without any changes.

screen shot 2018-06-12 at 4 59 53 pm

oshamahue commented 6 years ago

I think it is still worth it to merge the pr. Because when a new library version is released on google repo it will take some time for JCenter to get updated. We will have similar problems.

starkej2 commented 6 years ago

Does jcenter mirror google's maven repo? I don't think that's the case. If it were true the project would still build without the google() repository

oshamahue commented 6 years ago

you can check this out. https://twitter.com/dannyroa/status/1004327241826762752