meson: Fix check for builtype arguments

ebassi / graphene

A thin layer of graphic data types

http://ebassi.github.io/graphene

Other

376 stars 82 forks source link

meson: Fix check for builtype arguments #183

Closed nirbheek closed 4 years ago

nirbheek commented 4 years ago

get_option('buildtype') will return 'custom' for most combinations of -Doptimization and -Ddebug, but those two will always be set correctly if only -Dbuildtype is set. So we should look at those options directly.

For the two-way mapping between buildtype and optimization + debug, see this table: https://mesonbuild.com/Builtin-options.html#build-type-options

Same change as glib: https://gitlab.gnome.org/GNOME/glib/merge_requests/1433

nirbheek commented 4 years ago

Test failure seems to be unrelated?

4/21 graphene / box ERROR 0.988502025604248 s

ebassi commented 4 years ago

@nirbheek The transient failure in the graphene_box_t on MSYS2/x86 is known.

nirbheek commented 4 years ago

Should I re-push till the test passes?

ebassi commented 4 years ago

Nah, it's just annoying, and I care very little about 32bit platforms.