search

ebassi / graphene

A thin layer of graphic data types
http://ebassi.github.io/graphene
Other
376 stars 82 forks source link

Windows: use _isnanf macro instead of fallback #189

Closed vtorri closed 4 years ago

ebassi commented 4 years ago

Sadly, this breaks on MSVC 32bit:

../src/graphene-ray.c(535): error C4013: '_isnanf' undefined; assuming extern returning int
vtorri commented 4 years ago

accroding to msdn

The _isnan and _isnanf functions are Microsoft-specific. The _isnanf function is only available when compiled for x64.

i'm going to fix this

vtorri commented 4 years ago

arg ! i've written 32 bits instead of 64 bits

vtorri commented 4 years ago

@ebassi do i close this PR and create another one (because of my wrong message) ?

ebassi commented 4 years ago

@ebassi do i close this PR and create another one (because of my wrong message) ?

No. You can edit the commit and then force push to your branch. The merge request will be updated.

ebassi commented 4 years ago

I'd also squash both commits into a single one, so that we don't break the tests when bisecting.