search

ebassi / graphene

A thin layer of graphic data types
http://ebassi.github.io/graphene
Other
373 stars 80 forks source link

meson: add pthreads option #268

Closed ffontaine closed 1 month ago

ffontaine commented 1 month ago

Allow the user to disable pthreads

ebassi commented 1 month ago

Why? What kind of platform is this, that does not have pthread?

Care to elaborate what is the goal of adding a build time option that I am going to support?

ffontaine commented 1 month ago

uclibc-ng can be configured without threads support. This configuration can be used by users on some embedded systems (microcontrollers). If this PR is not acceptable, I'll add a dependency on threads for graphene on buildroot side.

ebassi commented 1 month ago

I very much doubt anybody will ever use graphene on microcontrollers, considering the nature of the project; unless there are microcontrollers with vector instructions somewhere…

If this PR is not acceptable, I'll add a dependency on threads for graphene on buildroot side.

I think it's more appropriate to add a dependency. I definitely do not test Graphene without a platform threading implementation, so I can't ensure it'll ever work.

Thanks for your contribution, in any case.