search

ebassi / graphene

A thin layer of graphic data types
http://ebassi.github.io/graphene
Other
376 stars 82 forks source link

vapigen produces invalid code #59

Closed AstraLuma closed 8 years ago

AstraLuma commented 8 years ago

This is either a bug in vapigen or in graphene's GIRs.

I ran vapigen on the graphene gir and all the res arguments had out unowned modifiers on them. This causes vala to attempt to double-redirect for them, which is wrong.

ebassi commented 8 years ago

Pretty sure the introspection data is valid, so this may be a bug in the vapigen interpretation.

AstraLuma commented 8 years ago

Of lesser note: The header is incorrect in the gir. For some reason, it's saying the header is graphene-object.h.

ebassi commented 8 years ago

The header is correct: the GTypes for Graphene (which are used by introspection) is graphene-gobject.h. graphene.h is the pure C library.

AstraLuma commented 8 years ago

The header is missing the 'g'.

ebassi commented 8 years ago

Oh, didn't notice that. Fixed in master.

AstraLuma commented 8 years ago

I'm also discussing this in vala #764872.

After looking at the gir, I think this is a bug in vapigen, but I'm still pretty new to vala.

ebassi commented 8 years ago

Closing, as the discussion is ongoing in the Vala bug tracker.