Closed eevan78 closed 7 months ago
@eevan78 interesting, let me look into this. It might be something fixed with version 2024.1.13, so as soon as the EXE is uploaded, can you retry with that binary?
In the meantime, I don't capture the FFmpeg stderr because the operations that tidal-wave
is doing are re-muxing, not encoding or decoding, so they should be trivial. However, I have not tested much on Windows, so I will look into this issue and get back to you.
@eevan78 I have figured out the issue (I believe). Using the same 2024.1.12 binary on Windows 10, it turns out that the problem is a Windows problem: Illegal character in file name
. So, I will have to put some more effort into sanitizing the track names. A fix will be out soon, which will entail a new version.
@eevan78 I have figured out the issue (I believe). Using the same 2024.1.12 binary on Windows 10, it turns out that the problem is a Windows problem:
Illegal character in file name
. So, I will have to put some more effort into sanitizing the track names. A fix will be out soon, which will entail a new version.
@eevan78 having solved the problem mentioned above, I've run into an issue on track 23 of the album you originally linked to. I'm confident that the file name is too long for Windows; there is a 260-character limitation, so I will have to add some more logic to keep (absolute) file names under that limit. Will be ready in version 2024.1.14.
Thanks a lot!
It would be nice to have some sort of naming template, but if it's
complicated to implement, then better to leave it like this.
I tend to name tracks on all albums as Track_nn
as
I never search tracks using filename. So I'm keeping the filename short.
But that's only me... Other people prefer something else.
уто, 30. јан 2024. 02:12 Colin Coe @.***> је написао/ла:
@eevan78 https://github.com/eevan78 I have figured out the issue (I believe). Using the same 2024.1.12 binary on Windows 10, it turns out that the problem is a Windows problem: Illegal character in file name. So, I will have to put some more effort into sanitizing the track names. A fix will be out soon, which will entail a new version.
@eevan78 https://github.com/eevan78 having solved the problem mentioned above, I've run into an issue on track 23 of the album you originally linked to. I'm confident that the file name is too long for Windows; there is a 260-character https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#maximum-path-length-limitation limitation, so I will have to add some more logic to keep (absolute) file names under that limit. Will be ready in version 2024.1.14.
— Reply to this email directly, view it on GitHub https://github.com/ebb-earl-co/tidal-wave/issues/62#issuecomment-1915666212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGSMGQUZDZL65W4FKTG4BM3YRANEDAVCNFSM6AAAAABCN76MG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGY3DMMRRGI . You are receiving this because you were mentioned.Message ID: @.***>
@eevan78 a configuration for naming template is an option, but I am loath to introduce the complexity... I started this thinking that users of the project could rename however they like once they've got the files downloaded.
This here issue should be solved in the newest version, 2024.1.15. Please give it a go and report back!
@ebb-earl-co I have tried the newest version, and I can confirm that it is working properly on Windows. Thanks for a fix!
Hi, I use a statically linked almost latest full FFmpeg build and tidal-wave on Windows:
I was trying to download the following album in HiRes. It goes well up to the track no. 17, and then it fails with the following:
After that I was experimenting only with that track. The command used to download the track was:
It also fails with the same error whne I use the absolute path, like
c:\1
I'm not sure how to capture the stderr, so I don't kow what is FFmpeg complaining about.