Disallow Illegal Characters in File Names on Windows

ebb-earl-co / tidal-wave

Waving at the TIDAL music service

Apache License 2.0

38 stars 2 forks source link

Disallow Illegal Characters in File Names on Windows #65

Closed ebb-earl-co closed 7 months ago

ebb-earl-co commented 7 months ago

This pull request hopefully :crossed_fingers: solves issues such as #62 which arise from illegal characters attempting to be in file names on Windows. On macOS and GNU/Linux systems, this is less of a problem, but still a problem, so let's squash it here.

ebb-earl-co commented 7 months ago

Furthermore, this pull request addresses another bug found in #62 : Windows has a 260-character absolute file name limit. Thus, logic has been added to track.Track.set_outfile() such that, if the absolute file name is longer than 260 characters, truncate it to just the track number and codec; e.g. 23.flac. If this is still too long, then log a warning and return early.

ebb-earl-co commented 7 months ago

Then, in this (probably too-large) pull request, multiple GitHub actions have been changed in order to :crossed_fingers: more robustly upload artifacts upon cutting a release.