ebbba-org / ansible-role-bigbluebutton

Ansible role for a bigbluebutton installation (following the documentation on https://docs.bigbluebutton.org/administration/install and https://github.com/bigbluebutton/bigbluebutton)
https://www.ebbba.org/
MIT License
126 stars 82 forks source link

Added bbb_docker_python_version variable #372

Closed simoncolincap closed 5 months ago

simoncolincap commented 10 months ago

Fixes https://github.com/ebbba-org/ansible-role-bigbluebutton/issues/371 by setting a specific version for the Docker Python package.

BrutalBirdie commented 10 months ago

Hmm something is up the full deployment test. Need to check that out.

cherbst commented 10 months ago

Having the same problem

GUFFMHRZ commented 10 months ago

Same here, Nodes get thrown out of monitoring after running the role including the PR

berott commented 10 months ago

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

BrutalBirdie commented 10 months ago

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

Oh! Did not even notice that. Yes right, should actually be merged against the master branch. I have adjusted that.

BrutalBirdie commented 10 months ago

The full deployment test still fails: https://github.com/ebbba-org/ansible-role-bigbluebutton/actions/runs/7182177988/job/20047264408?pr=372#step:6:3932

I will check this out now.

BrutalBirdie commented 10 months ago

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

berott commented 10 months ago

I use the following monitoring-configuration:

    bbb_monitoring_all_in_one_enable: true
    bbb_monitoring_all_in_one_grafana: false
    bbb_monitoring_all_in_one_prometheus: false
    bbb_monitoring_recordings_from_disk: false
    bbb_monitoring_external: true
    bbb_monitoring_htpasswd_user: "{{bbb_mon_user}}"
    bbb_monitoring_htpasswd: "{{bbb_mon_pass}}"
    bbb_monitoring_systemd_enable: false

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"
GUFFMHRZ commented 10 months ago

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

Hi, we're running:

- name: Install python docker packages
  pip:
    name:
      - docker=={{ bbb_docker_python_version }}
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"
# https://pypi.org/project/docker/#history
bbb_docker_python_version: 6.1.3
# https://pypi.org/project/docker-compose/#history
bbb_docker_compose_version: 1.29.2

and

bbb_monitoring_all_in_one_enable: yes
bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_exporter_version: latest
bbb_monitoring_external: true
GUFFMHRZ commented 10 months ago

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"

This did not help us

cherbst commented 10 months ago

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

What I meant to say was that this PR fixes the problem in #371, not that I have a problem with this PR. We have

bbb_monitoring_all_in_one_enable: true

and none of the other monitoring settings.

BrutalBirdie commented 5 months ago

Sorry for not doing anything here for so long. But now I finally hit this rock again :D

Came back to the issue and starting thinking. We should switch to community.docker.docker_compose_v2

Since it only needs:

Docker CLI with Docker compose plugin 2.18.0 or later

    PyYAML if [definition](https://docs.ansible.com/ansible/latest/collections/community/docker/docker_compose_v2_module.html#ansible-collections-community-docker-docker-compose-v2-module-parameter-definition) is used

and the pip package can be gone.

Thoughts?

EDIT: After looking at the old version, it has been marked as DEPRECATED anyway :) So I will close this PR and push a new one with the new changes.