search

ebceu4 / protobuf-csharp-port

Automatically exported from code.google.com/p/protobuf-csharp-port
0 stars 0 forks source link

Message with Field same name as message causes uncompilable .cs #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Sample proto:

  package Test;

  import "google/protobuf/csharp_options.proto";

  option (google.protobuf.csharp_file_options).namespace = "Test";
  option (google.protobuf.csharp_file_options).umbrella_classname = "TestContainer";

  option optimize_for = SPEED;

  message A {
     optional int32 _A = 1;
  }

This is supported in the Java version, so we should really try to make it work.

Original issue reported on code.google.com by jonathan.skeet on 5 Apr 2011 at 4:10

GoogleCodeExporter commented 9 years ago 
Would be great if we can get this fixed?

Original comment by sharat.k...@gmail.com on 29 Jul 2011 at 10:34

GoogleCodeExporter commented 9 years ago 
It would certainly be *nice*, but I'm not sure it "would be great" - I haven't 
seen it be a huge issue for folks.

Put it this way - I'm glad it's still in the issue list, but currently my 
protobuf time is being spent reviewing new code for other things.

Original comment by jonsk...@google.com on 29 Jul 2011 at 10:49

GoogleCodeExporter commented 9 years ago 
Issue identified in UnderscoresToCamelCase -> UnderscoresToPascalOrCamelCase

The '_' prefix is causing the capitalization of the first character even when 
building camelCase names.  Due to this the public property and private field 
both are named "A_" .

Fix pending review:
http://code.google.com/p/protobuf-csharp-port/source/list?name=issue-13

Original comment by Grig...@gmail.com on 12 Aug 2011 at 11:42

GoogleCodeExporter commented 9 years ago 
Status reverted to Started, until post-merge

Original comment by Grig...@gmail.com on 13 Aug 2011 at 1:20

GoogleCodeExporter commented 9 years ago 
The requested change has been completed.

Original comment by Grig...@gmail.com on 13 Aug 2011 at 11:30