Restructuring - Githubissues

ebcrowder / rust_ledger

Rust implementation of ledger, the command line accounting tool.

GNU General Public License v3.0

137 stars 19 forks source link

Restructuring #13

Closed ebcrowder closed 4 years ago

ebcrowder commented 4 years ago

adds more robust logic for better error handling and messaging
moves the logic contained in the various modules into struct methods. This improves readability but also removes duplicate and unnecessary data structures.
rename the modules to singular verbs for consistency
replace integration tests with unit tests. Right now, the tests don't add a ton of value as they do not assert the stdout output but this is a good starting place. Besides, the previous tests did not add a lot of value, either.
compile times are much faster because we were able to drop hefty dev dependencies that were used by the integration tests.
dependency updates

ebcrowder commented 4 years ago

alrighty @dantuck - this is ready to go now.

Since it has been a while since I have published a version of this to crates.io, I'll do that after this gets merged.

ebcrowder commented 4 years ago

Or something similar. I have been making some implementation changes to error output in another project that you could probably implement here.

Great - please do let me know what you find. I spent some time trying to figure out how to parse the default Error output but couldn't figure out a way to do it. I'm guessing the display() fn would be the place to do it.

I'll merge this in the meantime. Appreciate the quick review!