Refactor code repetition (structs definitions)

ebcrowder / rust_ledger

Rust implementation of ledger, the command line accounting tool.

GNU General Public License v3.0

137 stars 21 forks source link

Refactor code repetition (structs definitions) #2

Closed bar9 closed 4 years ago

bar9 commented 4 years ago

Hi Eric I am interested in this project and would like to contribute. One thing that struck me was that structs are defined multiple times, e.g. Accounts or Currencies. This will be hard to maintain. They could be moved to a types.rs or models.rs file and imported to the other files. Can I open a PR for this? Are you interested in contributions? Cheers

ebcrowder commented 4 years ago

@bar9 This is a great idea and will clean up the code quite a bit. Please do submit a PR!