ebean-orm-tools / ebean-eclipse-enhancer

Eclipse plugin for Ebean ORM enhancement
3 stars 7 forks source link

Agent Update & GroupId Change #4

Closed rPraml closed 8 years ago

rPraml commented 8 years ago

Hello Rob, I've updated the agents in the eclipse-enhancer and added logging for QueryBeanTransformer. There was also a missing dependency for "querybean-agent" which I have corrected (otherwise the artifact was not put into the /lib folder)

cheers Roland

netwolfuk commented 8 years ago

Shouldn't the second reference to 4.x.x also be updated to 8.x.x ?

...if you are using ebean 4.x.x. updated to ...if you are using ebean 8.x.x.

https://github.com/ebean-orm/ebean-eclipse-enhancer/pull/4/commits/e6b6803f4aaec83e86b803873919b0594442cae3#diff-04c6e90faac2675aa89e2176d2eec7d8R4

For example

+ebean orm eclipse plugin for auto enhancement using the 8.x.x java agent - you **must** use this version of the plugin if you are using ebean 8.x.x.
rPraml commented 8 years ago

Not sure, Rob changed nearly all versions/groupIds. Everything seems to be 8.x now. But the agent should still work with ebean 4.x (not tested). @rbygrave BTW: there are still groupIds like "com.avaje" for the eclipse plugin. Maybe we should that change to "org.avaje", too?

rbygrave commented 8 years ago

BTW: there are still groupIds like "com.avaje" for the eclipse plugin. Maybe we should that change to "org.avaje", too?

Yes, probably. The eclipse plugin doesn't go into maven central so that issue has not really been picked up before.

On 23 August 2016 at 00:51, Roland Praml notifications@github.com wrote:

Not sure, Rob changed nearly all versions/groupIds. Everything seems to be 8.x now. But the agent should still work with ebean 4.x (not tested). @rbygrave https://github.com/rbygrave BTW: there are still groupIds like "com.avaje" for the eclipse plugin. Maybe we should that change to "org.avaje", too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ebean-orm/ebean-eclipse-enhancer/pull/4#issuecomment-241402912, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMwTbGoBcJgKfADABfSadlcbETNex1pks5qiZtZgaJpZM4JpEsp .