search

ebean-orm-tools / ebean-gradle-plugin

Plugin that performs Enhancement (entity, transactional, query bean) and can generate query beans from entity beans written in Kotlin via kapt
Apache License 2.0
10 stars 12 forks source link

Fix: gradle plugin #16

Closed vnnv closed 6 years ago

vnnv commented 6 years ago

Fix: > Plugin with id 'ebean' not found.

because ebean.properties was renamed to io.ebean.properties ebean plugin can not be started using apply plugin: ebean

I alse updated README.md - using latest eben versions. Please review and merge.

rbygrave commented 6 years ago

It looks good except for that rename of the io.ebean.properties file ... I think that file name needs to match the plugin id which changed from "ebean" to "io.ebean"

... but yes I'll merge it in shortly and check.

Cheers, Rob.

vnnv commented 6 years ago

if the file is named io.ebean.properties gradle can not find the plugin using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean' than. I did not check that. But if we want to use 'ebean' as plugin name the file must be ebean.properties

rbygrave commented 6 years ago

Yes, we need to use:

apply plugin: 'io.ebean'

We had to change the name to 'io.ebean' to deploy to the Gradle plugins repo. That is how the plugin is deployed now to both to the gradle repo and maven central. So note that if we are not using 'io.ebean' ... we are not using the latest released plugin.

On 21 February 2018 at 11:05, Victor Nike notifications@github.com wrote:

if the file is named io.ebean.properties gradle can not find the plugin using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean' than. I did not check that. But if we want to use 'ebean' as plugin name the file must be ebean.properties

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ebean-orm-tools/ebean-gradle-plugin/pull/16#issuecomment-367136581, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMwTdTcS3_cEeYEUpJ9Xsv0bVdeI1Deks5tW0GXgaJpZM4SK_QX .

rbygrave commented 6 years ago

Also, docs are at: http://ebean-orm.github.io/docs/tooling/gradle

... so we need to review those.

On 21 February 2018 at 11:31, Rob Bygrave robin.bygrave@gmail.com wrote:

Yes, we need to use:

apply plugin: 'io.ebean'

We had to change the name to 'io.ebean' to deploy to the Gradle plugins repo. That is how the plugin is deployed now to both to the gradle repo and maven central. So note that if we are not using 'io.ebean' ... we are not using the latest released plugin.

On 21 February 2018 at 11:05, Victor Nike notifications@github.com wrote:

if the file is named io.ebean.properties gradle can not find the plugin using apply plugin: 'ebean'. Maybe one must use apply plugin: 'io.ebean' than. I did not check that. But if we want to use 'ebean' as plugin name the file must be ebean.properties

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ebean-orm-tools/ebean-gradle-plugin/pull/16#issuecomment-367136581, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMwTdTcS3_cEeYEUpJ9Xsv0bVdeI1Deks5tW0GXgaJpZM4SK_QX .

vnnv commented 6 years ago

In that case maybe only README should be merged along with changes to use io.ebean

rbygrave commented 6 years ago

Updated the README - should be all good now, closing.