search

ebean-orm-tools / ebean-gradle-plugin

Plugin that performs Enhancement (entity, transactional, query bean) and can generate query beans from entity beans written in Kotlin via kapt
Apache License 2.0
10 stars 12 forks source link

Cachable (incremental) enhancement #26

Closed soberich closed 5 years ago

soberich commented 5 years ago

Please, see if it works as expected. I've tried to just add the desired functionality and not to refactor anything. It works for me, don't know it it is possible that it brakes something or not.

EDIT

Just checked. It works for me equally for Java, Kotlin projects, mixed JVM projects multi-module projects.

EDIT 2

I have seen PRs https://github.com/ebean-orm-tools/ebean-gradle-plugin/pull/23 and issue https://github.com/ebean-orm-tools/ebean-gradle-plugin/issues/22

@Keltas359 @tobias- please check this pr. Works for me with caching on all sort of projects with clean test and any other combination.

soberich commented 5 years ago

@Keltas359 just a ping as I don't know if you get notified after adding mention when it is added not originally.

Keltas359 commented 5 years ago

Tried it with my Kotlin project. Caching works fine with Gradle 5.2.1, 4.10.2, test and assemble tasks. Didn't notice any issues.

rbygrave commented 5 years ago

At first look this looks like a good change. I hope to look again in a couple of days and try it myself. Let me know how your own testing goes with it.

Thanks, Rob.